-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change icon of Team Status Sensor to real Teams Icon #80
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.77%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
I've not tested it, but you can probably use the icon property for this, rather than extra_attributes. Certainly works for media_player not sure if it works for sensor.
|
You are right, changed it. |
I'll have a look at this some more tomorrow, and probably add icons for the chat sensor (teams), and the inbox sensors (outlook). I'm just implementing a tasks/todo sensor, so will look if there is anything appropriate for that. Great idea. Thanks |
It's my pleasure. Here are some ideas for other icons. For Chat: |
The icon of the Teams Status Sensor is just the default eye icon. The Teams icon is available in the icons library. This PR will use the Teams Icon in the Teams Status Sensor.
Before
After