Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch exposed kvrock client to interface #60

Merged
merged 6 commits into from
Nov 19, 2023

Conversation

jiayinzhang-mint
Copy link
Contributor

Changes

  • Construct kvrock client as a interface, which shall be easier to mock for future tests.
  • Rename sigs.k8s.io/controller-runtime/pkg/client to k8sApiClient to avoid confusion.
  • Add necessary comments to kvrock client methods.

@jiayouxujin jiayouxujin self-requested a review November 19, 2023 06:33
@jiayouxujin
Copy link
Collaborator

Hi, @jiayinzhang-mint
I noticed that your PR has some conflicts with the base branch. Could you please rebase it to resolve these issues?

@jiayinzhang-mint
Copy link
Contributor Author

Hi, @jiayinzhang-mint I noticed that your PR has some conflicts with the base branch. Could you please rebase it to resolve these issues?

Done.

Copy link
Collaborator

@jiayouxujin jiayouxujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiayinzhang-mint
Copy link
Contributor Author

@jiayouxujin jiayouxujin merged commit 55299c6 into RocksLabs:unstable Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants