fix(message-parser): Phone pattern #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
approved these changes
Nov 14, 2022
|
@Mergifyio backport v0.31.22 |
❌ No backport have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The Phone code matches any plus sign (+) followed by one or more digits, regardless of whether it is a valid phone number.
To fix this behavior we are now checking if the phone number has any other characters other than
(,)and-and at least 5 numbersSteps to reproduce:
In a chat, enter the text 1+1=2
Expected behavior:
The chat message should not contain any hyperlinks
other e.g:
Actual behavior:
The +1 is hyperlinked to tel:1 even though it is not a valid phone number.
Other e.g:
Issue(s)
RocketChat/Rocket.Chat#27141
Further comments
TC-250