Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Set version field on resolve-workspace-deps #552

Merged
merged 2 commits into from
Oct 1, 2021
Merged

build: Set version field on resolve-workspace-deps #552

merged 2 commits into from
Oct 1, 2021

Conversation

tassoevan
Copy link
Collaborator

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team October 1, 2021 20:10
@dougfabris dougfabris merged commit 0036c18 into develop Oct 1, 2021
@dougfabris dougfabris deleted the build/fix-resolve-workspace-deps branch October 1, 2021 21:43
ggazzo pushed a commit that referenced this pull request Oct 6, 2021
@dougfabris
build: Set version field on resolve-workspace-deps #552
e0e6c30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @dougfabris