feat(fuselage)!: Lighter Accordion and AccordionItem components
#1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef77fba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tassoevan
force-pushed
the
feat/lighter-accordion
branch
from
e6b8a04 to
ef77fba
Compare
dougfabris
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It removes an obsolete and not accessible toggle switch in
AccordionItemand eases the internal usage ofBoxtoimprove rendering performance.
Additionally, it adds a new
StylingBoxcomponent that can be used as a wrapper for components that accept stylingprops but don't need the weight of the
Boxcomponent prop handling internally.Also, it adds a new
cxandcxxhelpers to compose class names.Issue(s)
Further comments
An important tweak was made in Jest's setup, mocking
useUniqueIdcalls to return deterministic IDs, allowing snapshot matching.