Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): MenuItem onPointerUp event behavior #1422

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Aug 1, 2024

Proposed changes (including videos or screenshots)

Fixes Menu triggering pointerUp event immediately when Popover overlaps its Trigger button.
This solution is a workaround suggested on this issue on react-spectrum

Issue(s)

Further comments

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: d465487

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review August 1, 2024 21:12
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliajforesti juliajforesti merged commit 0df364b into main Aug 1, 2024
7 checks passed
@juliajforesti juliajforesti deleted the fix/menu-behavior branch August 1, 2024 21:37
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants