-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add ability to disable email notifications globally #9667
[NEW] Add ability to disable email notifications globally #9667
Conversation
Thanks for the contribution! Left a comment in line :) |
@ferdifly hi,when I find the issue of disabling email notification globally.I'm so glad.But I can't find in the 0.64.0 tag.Why this useful rp was not accepted. |
@howq Apparently my commit keeps all e-mails from being sent (see #3211 (comment)). Thanks for reminding me of this, I somehow lost track of this commit due to other stuff going on. I'll try to take a look at it later this week. |
up? |
Any update of this? |
Since interest still seems high on this feature I took a look at my branch again. According to my understanding of the code and terminal output, password recovery mails are still being sent when email notifications are disabled #3211 (comment). Maybe someone from @RocketChat/core could consider this PR again and let me know what there is left to do. Did my commit 23e0195 address @geekgonecrazy change request correctly? |
@geekgonecrazy I've addressed your change request and merged the latest develop branch. However |
That's fine and normal. @rocketchat/core this seems like a great change to add. I know I personally have needed something like this a few times for disabling email sending. |
@RocketChat/core
Closes #3211
I might add the option to hide message content later on but I think this will do as a first PR.
Please let me know how I can improve this PR (by adding some tests maybe?).
Screenshots:
![admin](https://user-images.githubusercontent.com/22708633/36044406-dc035f06-0dd2-11e8-90e4-e5e012e2b432.png)
![user](https://user-images.githubusercontent.com/22708633/36044407-dc1e9294-0dd2-11e8-9d2b-a5cfd1f1db35.png)