-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove leader bar from chat room header #35209
chore: remove leader bar from chat room header #35209
Conversation
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 34b9370 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/display-leader-role-members-list #35209 +/- ##
======================================================================
Coverage 59.43% 59.43%
======================================================================
Files 2825 2825
Lines 68155 68159 +4
Branches 15123 15126 +3
======================================================================
+ Hits 40505 40510 +5
- Misses 24992 24993 +1
+ Partials 2658 2656 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to merge this code with the one where we display the leaders in the members list. Otherwise we'll have a temporary version of the code with no leaders on the UI
38252de
into
feat/display-leader-role-members-list
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-975