Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leader bar from chat room header #35209

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Feb 14, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-975

@abhinavkrin abhinavkrin requested a review from a team as a code owner February 14, 2025 15:45
Copy link
Contributor

dionisio-bot bot commented Feb 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 34b9370

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (77ba160) to head (34b9370).
Report is 6 commits behind head on feat/display-leader-role-members-list.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                           @@
##           feat/display-leader-role-members-list   #35209   +/-   ##
======================================================================
  Coverage                                  59.43%   59.43%           
======================================================================
  Files                                       2825     2825           
  Lines                                      68155    68159    +4     
  Branches                                   15123    15126    +3     
======================================================================
+ Hits                                       40505    40510    +5     
- Misses                                     24992    24993    +1     
+ Partials                                    2658     2656    -2     
Flag Coverage Δ
unit 75.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto modified the milestones: 7.1.0, 7.4.0 Feb 17, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to merge this code with the one where we display the leaders in the members list. Otherwise we'll have a temporary version of the code with no leaders on the UI

@abhinavkrin abhinavkrin changed the base branch from develop to feat/display-leader-role-members-list February 18, 2025 23:20
@abhinavkrin abhinavkrin merged commit 38252de into feat/display-leader-role-members-list Feb 18, 2025
50 of 51 checks passed
@abhinavkrin abhinavkrin deleted the chore/remove-LeaderBar-from-room branch February 18, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants