Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: change API_Enable_Rate_Limiter_Limit_Time_Default value from 600000 to 60000 #35180

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

julio-rocketchat
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Feb 11, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 8ddd0d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.31%. Comparing base (e0f092e) to head (8ddd0d2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35180   +/-   ##
========================================
  Coverage    59.31%   59.31%           
========================================
  Files         2825     2825           
  Lines        68158    68158           
  Branches     15123    15123           
========================================
  Hits         40430    40430           
  Misses       24900    24900           
  Partials      2828     2828           
Flag Coverage Δ
unit 75.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego changed the title chore: change API_Enable_Rate_Limiter_Limit_Time_Default value from 600000 to 60000 regression: change API_Enable_Rate_Limiter_Limit_Time_Default value from 600000 to 60000 Feb 12, 2025
@sampaiodiego sampaiodiego merged commit ce0a5c3 into develop Feb 12, 2025
30 of 33 checks passed
@sampaiodiego sampaiodiego deleted the chore-fix-api-limit-time-default branch February 12, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants