Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid link/message in banner for invalid apps #35132

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Feb 5, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SUP-722

Copy link
Contributor

dionisio-bot bot commented Feb 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 2db74b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 7.4.0 milestone Feb 5, 2025
KevLehman
KevLehman previously approved these changes Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (1da75e7) to head (2db74b4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35132   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2825     2825           
  Lines        68162    68162           
  Branches     15128    15128           
========================================
  Hits         40509    40509           
  Misses       24996    24996           
  Partials      2657     2657           
Flag Coverage Δ
unit 75.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin force-pushed the fix/invalid-link-and-message-for-invalid-app-banner branch 2 times, most recently from fd309f1 to 8a94d07 Compare February 13, 2025 06:29
@abhinavkrin abhinavkrin force-pushed the fix/invalid-link-and-message-for-invalid-app-banner branch from 8a94d07 to 1524abc Compare February 13, 2025 18:59
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Abhinav, this code looks way better now.

@abhinavkrin abhinavkrin added the stat: QA assured Means it has been tested and approved by a company insider label Feb 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2025
@kodiakhq kodiakhq bot merged commit 893f4e4 into develop Feb 14, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/invalid-link-and-message-for-invalid-app-banner branch February 14, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants