fix: room converter errors out when converting livechat room closed by the visitor

[d-gubert]

Proposed changes (including videos or screenshots)

If the closer of a livechat room is the visitor, the closedBy property of the room will contain the visitor's id, not the user's - which crashed the conversion from app format to core format as the converter was always trying to fetch a user from the DB.

The behavior now checks for the closer property to correctly assign the value to the closedBy property when converting back from the app.

Issue(s)

Steps to test or reproduce

Further comments

Further changes will be done to types, however to make this a safely "backportable" PR, they will be done separately

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.31%. Comparing base (e0f092e) to head (090b598).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #35107   +/-   ##
========================================
  Coverage    59.31%   59.31%           
========================================
  Files         2825     2825           
  Lines        68158    68158           
  Branches     15123    15123           
========================================
  Hits         40430    40430           
  Misses       24900    24900           
  Partials      2828     2828           

Flag	Coverage Δ
unit	75.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35107/
Built to branch gh-pages at 2025-02-04 20:02 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[KevLehman]

A changeset maybe? :awesome:

[changeset-bot]

🦋 Changeset detected

Latest commit: 090b598

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR