Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: OmnichannelQueueInactivityMonitor #35073

Merged
merged 2 commits into from
Jan 31, 2025
Merged

test: OmnichannelQueueInactivityMonitor #35073

merged 2 commits into from
Jan 31, 2025

Conversation

KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-264

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 30, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc402c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.22%. Comparing base (64a4fa9) to head (dc402c6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35073      +/-   ##
===========================================
+ Coverage    59.12%   59.22%   +0.09%     
===========================================
  Files         2822     2824       +2     
  Lines        67849    68020     +171     
  Branches     15129    15135       +6     
===========================================
+ Hits         40116    40284     +168     
- Misses       24907    24909       +2     
- Partials      2826     2827       +1
Flag Coverage Δ
unit 75.17% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35073/

Built to branch gh-pages at 2025-01-31 14:56 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@KevLehman KevLehman marked this pull request as ready for review January 30, 2025 17:49
@KevLehman KevLehman requested a review from a team as a code owner January 30, 2025 17:49
@KevLehman KevLehman added this to the 7.4.0 milestone Jan 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 31, 2025
@kodiakhq kodiakhq bot merged commit a4f2102 into develop Jan 31, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the test/queueinactivitymonitor branch January 31, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapiarafael tapiarafael tapiarafael approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KevLehman @tapiarafael