Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Text Preview Feature #35037

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

closes #806

Steps to test or reproduce

Further comments

Screencast.from.2025-01-27.00-36-03.webm

@thepiyush-303 thepiyush-303 requested a review from a team as a code owner January 26, 2025 19:16
Copy link
Contributor

dionisio-bot bot commented Jan 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: a42a89b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.20%. Comparing base (a49eb98) to head (43a29e3).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35037   +/-   ##
========================================
  Coverage    59.20%   59.20%           
========================================
  Files         2823     2823           
  Lines        67972    67972           
  Branches     15120    15120           
========================================
  Hits         40245    40245           
  Misses       24900    24900           
  Partials      2827     2827           
Flag Coverage Δ
unit 75.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thepiyush-303
Copy link
Contributor Author

Hey @tassoevan
Could be please give a feedback on it.
Thanks.

@thepiyush-303
Copy link
Contributor Author

Hey @debdutdeb
could you please review my implementation of this feature? I think it would be a really cool addition!
If any changes required please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendered Message Preview
1 participant