Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove send confirmation email method calls (server) #35014

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

MarcosSpessatto
Copy link
Member

https://rocketchat.atlassian.net/browse/CORE-939

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: c2f248a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarcosSpessatto MarcosSpessatto added this to the 7.4.0 milestone Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35014/

Built to branch gh-pages at 2025-01-31 13:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (18ba1a0) to head (c2f248a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35014      +/-   ##
===========================================
- Coverage    59.12%   59.12%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        67856    67849       -7     
  Branches     15129    15129              
===========================================
- Hits         40122    40116       -6     
+ Misses       24908    24907       -1     
  Partials      2826     2826              
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review January 23, 2025 16:29
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner January 23, 2025 16:29
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 28, 2025
@kodiakhq kodiakhq bot merged commit 64a4fa9 into develop Jan 31, 2025
47 checks passed
@kodiakhq kodiakhq bot deleted the refactor/send-confirmation-method branch January 31, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants