Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove meteor from gitlab auth #34993

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jan 21, 2025

Copy link
Contributor

dionisio-bot bot commented Jan 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 0530b13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34993/

Built to branch gh-pages at 2025-01-21 17:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (fc06659) to head (0530b13).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34993   +/-   ##
========================================
  Coverage    59.21%   59.21%           
========================================
  Files         2824     2824           
  Lines        67995    67995           
  Branches     15123    15123           
========================================
  Hits         40263    40263           
  Misses       24902    24902           
  Partials      2830     2830           
Flag Coverage Δ
unit 75.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review January 21, 2025 18:58
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner January 21, 2025 18:58
@dougfabris dougfabris added this to the 7.4.0 milestone Feb 3, 2025
apps/meteor/app/gitlab/client/lib.ts Outdated Show resolved Hide resolved
apps/meteor/app/gitlab/client/lib.ts Outdated Show resolved Hide resolved
apps/meteor/app/gitlab/client/lib.ts Outdated Show resolved Hide resolved
apps/meteor/app/gitlab/client/lib.ts Show resolved Hide resolved
dougfabris
dougfabris previously approved these changes Feb 7, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Feb 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2025
@kodiakhq kodiakhq bot merged commit c216556 into develop Feb 10, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the remove-meteor-method/gitlab branch February 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants