Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slack Bridge when using multiple slack workspaces #34933

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Jan 10, 2025

Proposed changes (including videos or screenshots)

This PR addresses a bug with multiple slack adapters and Rocket.Chat that was introduced when bumping the version of @slack/bolt from 3.22.0 to 4.1.0.

Issue(s)

CORE-927

Steps to test or reproduce

Further comments

This is a temporary fix, though. We are currently working on migrating slack bridge to Typescript and this incompatibility will be fixed with the migration. Rolling back the package's version aims to make the feature available for customers in the short term while we work on the migration/improvements in the slack bridge service.

More details in this thread!

Copy link
Contributor

dionisio-bot bot commented Jan 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 327f924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34933/

Built to branch gh-pages at 2025-01-15 16:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (62660fc) to head (327f924).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34933   +/-   ##
========================================
  Coverage    59.13%   59.13%           
========================================
  Files         2819     2819           
  Lines        67871    67871           
  Branches     15117    15117           
========================================
  Hits         40133    40133           
  Misses       24907    24907           
  Partials      2831     2831           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Jan 10, 2025
@lucas-a-pelegrino lucas-a-pelegrino modified the milestones: 7.2.0, 7.3.0 Jan 10, 2025
@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review January 10, 2025 19:21
.changeset/thirty-vans-fry.md Outdated Show resolved Hide resolved
Co-authored-by: Matheus Barbosa Silva <[email protected]>
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jan 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 15, 2025
@kodiakhq kodiakhq bot merged commit 819e36c into develop Jan 15, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix-slack-bridge-version-incompatibility branch January 15, 2025 17:23
@lucas-a-pelegrino
Copy link
Member Author

/patch

@lucas-a-pelegrino lucas-a-pelegrino restored the fix-slack-bridge-version-incompatibility branch January 15, 2025 18:13
@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 15, 2025

Pull request #34946 added to Project: "Patch 7.2.1"

@scuciatto
Copy link
Member

/backport 7.1.1

Copy link
Contributor

dionisio-bot bot commented Jan 15, 2025

Pull request #34947 added to Project: "Patch 7.1.1"

@lucas-a-pelegrino
Copy link
Member Author

/bark

Copy link
Contributor

dionisio-bot bot commented Jan 15, 2025

AU AU

This was referenced Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants