-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Slack Bridge when using multiple slack workspaces #34933
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 327f924 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Matheus Barbosa Silva <[email protected]>
/patch |
/patch |
Pull request #34946 added to Project: "Patch 7.2.1" |
/backport 7.1.1 |
Pull request #34947 added to Project: "Patch 7.1.1" |
/bark |
AU AU |
Proposed changes (including videos or screenshots)
This PR addresses a bug with multiple slack adapters and Rocket.Chat that was introduced when bumping the version of
@slack/bolt
from3.22.0
to4.1.0
.Issue(s)
CORE-927
Steps to test or reproduce
Further comments
This is a temporary fix, though. We are currently working on migrating slack bridge to Typescript and this incompatibility will be fixed with the migration. Rolling back the package's version aims to make the feature available for customers in the short term while we work on the migration/improvements in the slack bridge service.
More details in this thread!