fix: Allow users to fetch the packageValue of settings on /settings endpoint

[KevLehman]

Proposed changes (including videos or screenshots)

Since fields param is deprecated (and it's disabled by default, behind an env var), there was no way to obtain the default value of the settings when using the settings endpoint.

The proposed solution is to use a new boolean flag that allows the requester to fetch the packageValue along with the current value when using the aforementioned endpoint.

Flag is includeDefaults

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-911

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 40751c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/core-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/livechat	Patch
@rocket.chat/cron	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34864/
Built to branch gh-pages at 2025-01-14 13:50 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (88be133) to head (40751c6).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #34864      +/-   ##
===========================================
+ Coverage    59.12%   59.16%   +0.03%     
===========================================
  Files         2819     2819              
  Lines        67938    67793     -145     
  Branches     15134    15080      -54     
===========================================
- Hits         40171    40109      -62     
+ Misses       24934    24862      -72     
+ Partials      2833     2822      -11     

Flag	Coverage Δ
unit	74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[debdutdeb]

Shouldn't this be a feat instead? I understand why it could be considered a fix, however it's a new thing that's being added?

Edit: or is it a fix to be able to ship it on patch releases for older versions?

[KevLehman]

Well, it's a funny story: this was working, then it stopped working, then this will make it work again. So in theory is a fix... but could be a feat as well (as a new thing is added).

But i'm inclined more to "fix" cause it was working in a way and it stopped working