Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rooms.hide endpoint #34208

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Dec 17, 2024

Proposed changes (including videos or screenshots)

This PR introduces a new endpoint rooms.hide responsible for hiding rooms without type-specific restrictions.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 8625bce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/rest-typings Minor
@rocket.chat/models Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (a59ae8c) to head (8625bce).
Report is 40 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34208      +/-   ##
===========================================
+ Coverage    59.22%   59.32%   +0.10%     
===========================================
  Files         2824     2826       +2     
  Lines        68069    68283     +214     
  Branches     15151    15164      +13     
===========================================
+ Hits         40314    40511     +197     
- Misses       24924    24938      +14     
- Partials      2831     2834       +3     
Flag Coverage Δ
unit 75.33% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34208/

Built to branch gh-pages at 2025-02-04 15:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/rooms.ts Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva force-pushed the feat/rooms-close-endpoint branch from 9189509 to 86e48fa Compare February 4, 2025 15:27
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 4, 2025 15:28
@aleksandernsilva aleksandernsilva requested review from a team as code owners February 4, 2025 15:28
apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva marked this pull request as draft February 10, 2025 16:49
apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva changed the title feat: rooms.close endpoint feat: rooms.hide endpoint Feb 10, 2025
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 12, 2025 12:45
@aleksandernsilva aleksandernsilva marked this pull request as draft February 12, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants