Added password placeholders in all .i18n.json files. Please check if … #34041
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this fixed the 'no placeholder' under password issue.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(i18n): add password placeholder for all i18n files
I have added a passwordplaceholder for all the .i18n.json files. This change globally adds placeholders for the password fields. While I faced some difficulty in reproducing the issue on my local setup, this modification should fix the issue as intended.
Issue(s):
This was the issue I’m trying to fix:
#34032
Steps to test or reproduce
The 'login' page should now effectively show a placeholder for the password form as 8 dots.
Further comments:
This is my first commit, and I would appreciate guidance on setting up the local environment to contribute more effectively to Rocket.Chat. I’m excited to continue contributing.