Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User sound preferences master volume and ringing volume #33902

Merged
merged 11 commits into from
Nov 19, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Nov 6, 2024

Proposed changes (including videos or screenshots)

This PR add's "Master volume" and "Call ringer volume" to the user preferences sound section.

Screenshot 2024-11-19 at 14 58 14

Issue(s)

CORE-782

Steps to test or reproduce

  • Access workspace
  • Open user preferences > Sound
  • Fields should be visible

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: e6bd9d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title feat: master volume and ringing volume for user sound preferences feat: user sound preferences master volume and ringing volume Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33902/
on branch gh-pages at 2024-11-19 18:19 UTC

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (c68cd1b) to head (e6bd9d4).
Report is 77 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33902      +/-   ##
===========================================
- Coverage    75.42%   75.18%   -0.24%     
===========================================
  Files          493      495       +2     
  Lines        21499    21600     +101     
  Branches      5337     5362      +25     
===========================================
+ Hits         16215    16241      +26     
- Misses        4644     4717      +73     
- Partials       640      642       +2     
Flag Coverage Δ
unit 75.18% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@aleksandernsilva aleksandernsilva changed the title feat: user sound preferences master volume and ringing volume feat: User sound preferences master volume and ringing volume Nov 18, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review November 18, 2024 20:53
@aleksandernsilva aleksandernsilva requested review from a team as code owners November 18, 2024 20:53
@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Nov 18, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Nov 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 19, 2024
@ggazzo ggazzo merged commit d1e6a73 into develop Nov 19, 2024
52 checks passed
@ggazzo ggazzo deleted the feat/master-volume branch November 19, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants