fix: engine restart process for Deno used wrong status

[d-gubert]

Proposed changes (including videos or screenshots)

Whenever the Deno subprocess of an app crashes, the Apps-Engine tries to restart it so we can keep the operation going. However, the app wasn't correctly reporting its status afterwards, and stayed at the constructed or initialized status, which the engine does not recognize as enabled.

Also, we're removing the limit for the number of times the Apps-Engine would restart an app. At this point, it is not possible to show the restart or process status information to the admin, so it would just cause confusion to see the app not working.

Issue(s)

SUP-690

Steps to test or reproduce

1. Start up the server
2. Grab the pid of the subprocess of any enabled app (either with ps aux | grep deno or by starting the server with DEBUG=appsEngine:* and checking the logs)
3. Kill that pid via the command line
4. The app should still show as "enabled" in the UI and should still function as expected

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 2376c4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/apps-engine	Patch
@rocket.chat/meteor	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33865/
on branch gh-pages at 2024-11-07 15:39 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (d90d7e9) to head (2376c4f).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33865   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files          493      493           
  Lines        21499    21499           
  Branches      5337     5337           
========================================
  Hits         16215    16215           
  Misses        4644     4644           
  Partials       640      640           

Flag	Coverage Δ
unit	75.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[d-gubert]

@KevLehman @debdutdeb I'm gonna need to ask you for help with QAing this 🙏

[d-gubert]

/backport 7.0.1

[dionisio-bot]

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.0.1-33865
git cherry-pick b4841cb7206d855d7a1bc7604683a5b4a48b7176
// solve the conflict
git push

after that just run /backport 7.0.1 again

[d-gubert]

/backport 7.0.1

[dionisio-bot]

Pull request #34149 added to Project: "Patch 7.0.1"