-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Message parser build command #33589
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33589 +/- ##
==============================================
Coverage 74.79% 74.79%
==============================================
Files 467 467
Lines 20646 20646
Branches 5264 5264
==============================================
Hits 15442 15442
Misses 4591 4591
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk why it isn't working with just webpack, but this definitely unblocks us.
the downside of this approach would be lack of control over version. but we already are using latest so we'll be good for now.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments