Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Message parser build command #33589

Closed
wants to merge 2 commits into from
Closed

Conversation

jeanfbrito
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@jeanfbrito jeanfbrito requested review from a team as code owners October 15, 2024 17:14
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 722fd22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the base branch from develop to release-7.0.0 October 15, 2024 17:37
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33589/
on branch gh-pages at 2024-10-15 17:54 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (fc807b0) to head (a138b73).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33589   +/-   ##
==============================================
  Coverage          74.79%   74.79%           
==============================================
  Files                467      467           
  Lines              20646    20646           
  Branches            5264     5264           
==============================================
  Hits               15442    15442           
  Misses              4591     4591           
  Partials             613      613           
Flag Coverage Δ
unit 74.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

debdutdeb
debdutdeb previously approved these changes Oct 15, 2024
Copy link
Member

@debdutdeb debdutdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why it isn't working with just webpack, but this definitely unblocks us.

ftr yarnpkg/yarn#6048

the downside of this approach would be lack of control over version. but we already are using latest so we'll be good for now.

@ggazzo ggazzo closed this Oct 16, 2024
@ggazzo ggazzo deleted the fix-message-parser branch October 16, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants