Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: make custom sounds page stop to use query param #33499

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Oct 8, 2024

This pull request addresses CORE-719 by updating the /api/v1/custom-sounds.list endpoint.

  • The name attribute has been moved out of the query parameter and is now placed directly at the root of the query parameters.
  • For backward compatibility, the query parameter will still be supported when the environment variable ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS is set, but this should be reserved for exceptional cases, not standard usage.

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: ec99cee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarcosSpessatto MarcosSpessatto added this to the 6.14 milestone Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33499/
on branch gh-pages at 2024-10-16 22:25 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@41dd1a8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33499   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim force-pushed the refactor/custom-sounds-query-param branch from e14bb4a to 14b991e Compare October 10, 2024 17:27
@ricardogarim ricardogarim modified the milestones: 6.14, 7.0 Oct 11, 2024
@ricardogarim ricardogarim changed the base branch from develop to release-7.0.0 October 11, 2024 21:04
@ricardogarim ricardogarim changed the title refactor: make custom sounds page stop to use query param chore!: make custom sounds page stop to use query param Oct 11, 2024
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 09c1b34 to 3099c34 Compare October 11, 2024 21:14
@ricardogarim ricardogarim force-pushed the refactor/custom-sounds-query-param branch 2 times, most recently from 0b19b2c to e895bf7 Compare October 11, 2024 22:30
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
@ricardogarim ricardogarim force-pushed the refactor/custom-sounds-query-param branch from 6e39b47 to a7cf65f Compare October 15, 2024 13:57
@ricardogarim ricardogarim marked this pull request as ready for review October 15, 2024 14:01
@ricardogarim ricardogarim requested review from a team as code owners October 15, 2024 14:01
ricardogarim
ricardogarim previously approved these changes Oct 15, 2024
@ggazzo ggazzo force-pushed the refactor/custom-sounds-query-param branch from a7cf65f to ec99cee Compare October 16, 2024 21:54
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit 0398aa1 into release-7.0.0 Oct 17, 2024
50 of 52 checks passed
@ggazzo ggazzo deleted the refactor/custom-sounds-query-param branch October 17, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants