-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: make custom sounds page stop to use query param #33499
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33499 +/- ##
================================================
Coverage ? 74.79%
================================================
Files ? 467
Lines ? 20641
Branches ? 5262
================================================
Hits ? 15439
Misses ? 4590
Partials ? 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
e14bb4a
to
14b991e
Compare
09c1b34
to
3099c34
Compare
0b19b2c
to
e895bf7
Compare
bfefe41
to
204272c
Compare
6e39b47
to
a7cf65f
Compare
a7cf65f
to
ec99cee
Compare
This pull request addresses CORE-719 by updating the
/api/v1/custom-sounds.list
endpoint.name
attribute has been moved out of the query parameter and is now placed directly at the root of the query parameters.ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS
is set, but this should be reserved for exceptional cases, not standard usage.