Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Private apps restrictions are not applied on license removal" #33409

Conversation

matheusbsilva137
Copy link
Contributor

Reverts #33400 due to a a business rule change decision

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Oct 1, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 1, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: f898119

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Oct 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-01 13:42 UTC

@matheusbsilva137 matheusbsilva137 merged commit 4d381ca into release-7.0.0 Oct 1, 2024
18 checks passed
@matheusbsilva137 matheusbsilva137 deleted the revert-33400-feat/disable-apps-license-removal branch October 1, 2024 13:42
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (3be059a) to head (f898119).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33409      +/-   ##
=================================================
- Coverage          75.68%   75.32%   -0.36%     
=================================================
  Files                430      383      -47     
  Lines              19898    19383     -515     
  Branches            5078     4980      -98     
=================================================
- Hits               15060    14601     -459     
+ Misses              4267     4212      -55     
+ Partials             571      570       -1     
Flag Coverage Δ
unit 75.32% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

gabriellsh pushed a commit that referenced this pull request Oct 7, 2024
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
debdutdeb pushed a commit that referenced this pull request Oct 18, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants