fix: livechat stuck unread counter on new messages #33229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: aa11286 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33229 +/- ##
===========================================
+ Coverage 58.58% 59.60% +1.01%
===========================================
Files 2737 2602 -135
Lines 65676 63664 -2012
Branches 14824 14289 -535
===========================================
- Hits 38477 37947 -530
+ Misses 24420 22998 -1422
+ Partials 2779 2719 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
changed the title
MarcosSpessatto
previously approved these changes
Sep 10, 2024
ricardogarim
force-pushed
the
fix/livechat-counter
branch
from
0bc5e79 to
8839035
Compare
chore: refactor processUnread for readability chore: add changeset r a
|
ricardogarim
force-pushed
the
fix/livechat-counter
branch
from
8839035 to
07b6320
Compare
ricardogarim
force-pushed
the
fix/livechat-counter
branch
from
de0d0c1 to
a3bb90f
Compare
abhinavkrin
previously approved these changes
Sep 23, 2024
ggazzo
approved these changes
Oct 1, 2024
jessicaschelly
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
MarcosSpessatto
approved these changes
Oct 9, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 10, 2024
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue described in CORE-674, where the unread message counter does not update when a livechat visitor, with the widget minimized, receives their first response from an agent. The problem occurs because the
lastReadMessageIdis absent from the livechat client's state, and thegetUnreadMessagesfunction does not handle this situation correctly.Shoutout to @ggazzo for helping address the changes correctly within the widget code!