-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fuselage-ui-kit): MultiStaticSelectElement
not working as expected
#32999
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d49b8fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…dispatch-action-config
…cket.Chat into fix/dispatch-action-config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32999 +/- ##
===========================================
+ Coverage 59.31% 59.32% +0.01%
===========================================
Files 2547 2547
Lines 63343 63346 +3
Branches 14252 14254 +2
===========================================
+ Hits 37570 37581 +11
+ Misses 23070 23062 -8
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing 'on_item_selected'
or not passing it makes no difference to the unit test. Even reverting the useUiKitState
hook just fail the test in both scenarios.
MultiStaticSelectElement
not working as expected using dispatchActionConfig: ['on_item_selected']
MultiStaticSelectElement
not working as expected using
MultiStaticSelectElement
not working as expected usingMultiStaticSelectElement
not working as expected
…ted (#32999) Co-authored-by: Tasso Evangelista <[email protected]>
Proposed changes (including videos or screenshots)
Change actionFunction in useUiKitState to update the state value correctly when using MultiStaticSelectElement from UiKit
Issue(s)
Steps to test or reproduce
Further comments
SUP-629