Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent destructuring _id of deleted users #32899

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 25, 2024

During the user deletion, if the user is logged in, the server will throw an error

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: 07262d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (978e2d1) to head (07262d8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32899      +/-   ##
===========================================
+ Coverage    55.53%   55.55%   +0.02%     
===========================================
  Files         2637     2637              
  Lines        57439    57439              
  Branches     11903    11903              
===========================================
+ Hits         31897    31910      +13     
+ Misses       22823    22817       -6     
+ Partials      2719     2712       -7     
Flag Coverage Δ
e2e 54.07% <ø> (+0.01%) ⬆️
unit 72.37% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review July 25, 2024 13:17
@ggazzo ggazzo requested review from a team as code owners July 25, 2024 13:17
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 25, 2024
@ggazzo ggazzo added this to the 6.12 milestone Jul 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 25, 2024
@ggazzo ggazzo merged commit 7442ffc into develop Jul 25, 2024
53 of 54 checks passed
@ggazzo ggazzo deleted the chore/onlogout-typings branch July 25, 2024 18:30
gabriellsh added a commit that referenced this pull request Jul 31, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  chore: Bump rocket.chat to 6.12.0-develop (#32936)
  test: Move Jest configuration to a package of presets (#32802)
  chore: bump turbo (#32938)
  feat: New users page deactivated tab and active tab ui (#32032)
  chore: bump traefik (#32892)
  test: fix flaky test `Archive department` (#32933)
  fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928)
  refactor: Remove deprecated `Options.AvatarSize` constant (#32909)
  chore: improve `on login` cached collection (#32929)
  i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908)
  refactor: Circular imports (#32885)
  regression: notify user properly on logout (#32920)
  chore(client): stop replacing  `Meteor.user` (#32910)
  regression: Messagebox sending message instead of just selecting popup suggestion (#32890)
  refactor: move broadcastMessageFromData to notifyListener (#32843)
  chore: prevent destructuring _id of deleted users (#32899)
  ci: increase kernel limits (#32902)
  ci: lint issues
  Release 6.10.1
  fix: imported fixes (#32894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants