Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change user created page message from string to states #30806

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Oct 30, 2023

Proposed changes (including videos or screenshots)

Changed the simple string that was shown in the user created page to the states component and updated the toast message to follow figma specs.

Demo image:

Issue(s)

Steps to test or reproduce

Further comments

Changed the simple string that was shown in the user created page to the states component and updated the toast message to follow figma specs.
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: a94c507

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #30806 (a94c507) into feat/user-panel (32963e1) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/user-panel   #30806      +/-   ##
===================================================
- Coverage            51.22%   51.15%   -0.08%     
===================================================
  Files                  818      819       +1     
  Lines                15294    15298       +4     
  Branches              2840     2840              
===================================================
- Hits                  7835     7826       -9     
- Misses                7012     7024      +12     
- Partials               447      448       +1     
Flag Coverage Δ
e2e 48.33% <ø> (-0.09%) ⬇️
unit 64.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously requested changes Oct 30, 2023
apps/meteor/client/views/admin/users/AdminUserCreated.tsx Outdated Show resolved Hide resolved
@rique223 rique223 marked this pull request as ready for review October 31, 2023 03:48
@rique223 rique223 requested a review from a team as a code owner October 31, 2023 03:48
@rique223 rique223 marked this pull request as draft October 31, 2023 14:54
Implemented the plurals functionality in the user created page instead of manually verifying the number of created users.
@rique223 rique223 requested a review from ggazzo November 1, 2023 18:45
@rique223 rique223 marked this pull request as ready for review November 1, 2023 20:26
@ggazzo ggazzo changed the title refactor: Change user created page message from string to states chore: Change user created page message from string to states Nov 2, 2023
@hugocostadev hugocostadev merged commit 86c6469 into feat/user-panel Nov 3, 2023
@hugocostadev hugocostadev deleted the chore/new-user-success branch November 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants