Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update status-bullet colors #29316

Merged
merged 5 commits into from
May 24, 2023
Merged

chore: update status-bullet colors #29316

merged 5 commits into from
May 24, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 22, 2023

DSAR-164

Proposed changes (including videos or screenshots)

Update status-bullet colors on dark-mode:

from:
image

to:
image

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

⚠️ No Changeset found

Latest commit: 8d330d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #29316 (8d330d9) into develop (d40e4c0) will decrease coverage by 2.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29316      +/-   ##
===========================================
- Coverage    46.79%   44.59%   -2.21%     
===========================================
  Files          707      662      -45     
  Lines        13241    12139    -1102     
  Branches      2221     2083     -138     
===========================================
- Hits          6196     5413     -783     
+ Misses        6729     6439     -290     
+ Partials       316      287      -29     
Flag Coverage Δ
e2e 44.58% <ø> (-2.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review May 22, 2023 19:57
@juliajforesti juliajforesti requested a review from a team May 22, 2023 19:58
@dougfabris dougfabris added this to the 6.3.0 milestone May 24, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels May 24, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels May 24, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 24, 2023
@ggazzo ggazzo merged commit a49e91c into develop May 24, 2023
@ggazzo ggazzo deleted the chore/status-bullet-colors branch May 24, 2023 22:18
gabriellsh added a commit that referenced this pull request May 26, 2023
…ove/mentions

* 'develop' of github.com:RocketChat/Rocket.Chat: (48 commits)
  fix: Changed contact form async validations to onSubmit (#29250)
  refactor: Omnichannel Department re-write (#28948)
  feat: Added attachments to contact history message list (#29336)
  fix: Clicking uploaded file title replaces current tab (#29174)
  fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367)
  regression: Missing loading indicator (#29374)
  fix: Added check if count is truthy on `cleanRoomHistory` (#28081)
  chore: small tricks with keys and invalidations with marketplace page (#29369)
  fix: Missing await on agent leave action (#29358)
  refactor: useQuery for Marketplace Lists (#29348)
  test: add missing omnichannel contact-center tests (#28989)
  ci: omit vite log (#29360)
  chore: update `status-warning-2` color (#29321)
  fix: File upload in Safari, IOS devices (#27121)
  chore: update status-bullet colors (#29316)
  chore: `Contextualbar` empty state consistency (#29341)
  chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866)
  feat(apps): Disabling apps on trial license expiration (#29037)
  chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865)
  chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917)
  ...
gabriellsh added a commit that referenced this pull request May 26, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  fix: Changed contact form async validations to onSubmit (#29250)
  refactor: Omnichannel Department re-write (#28948)
  feat: Added attachments to contact history message list (#29336)
  fix: Clicking uploaded file title replaces current tab (#29174)
  fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367)
  regression: Missing loading indicator (#29374)
  fix: Added check if count is truthy on `cleanRoomHistory` (#28081)
  chore: small tricks with keys and invalidations with marketplace page (#29369)
  fix: Missing await on agent leave action (#29358)
  refactor: useQuery for Marketplace Lists (#29348)
  test: add missing omnichannel contact-center tests (#28989)
  ci: omit vite log (#29360)
  chore: update `status-warning-2` color (#29321)
  fix: File upload in Safari, IOS devices (#27121)
  chore: update status-bullet colors (#29316)
  chore: `Contextualbar` empty state consistency (#29341)
  chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866)
  feat(apps): Disabling apps on trial license expiration (#29037)
  chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865)
  chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants