-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Omnichannel contact table #29238
fix: Omnichannel contact table #29238
Conversation
@ggazzo @hugocostadev please provide feedback for this PR if I did something wrong that I should not it, I will work on it and learn from that, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, just need you to take a look on a few things 😉
apps/meteor/client/views/omnichannel/directory/contacts/ContactTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/directory/contacts/hooks/useCurrentContacts.ts
Outdated
Show resolved
Hide resolved
🦋 Changeset detectedLatest commit: e4006fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey, @Kishn0109. There's a couple o lint errors, can you take a look? |
Hi, @aleksandernsilva I have resolved all the linting errors. |
Codecov Report
@@ Coverage Diff @@
## develop #29238 +/- ##
===========================================
+ Coverage 44.79% 46.49% +1.69%
===========================================
Files 660 698 +38
Lines 12489 13031 +542
Branches 2202 2228 +26
===========================================
+ Hits 5595 6059 +464
- Misses 6571 6648 +77
- Partials 323 324 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Untitled.video.-.Made.with.Clipchamp.mp4
Issue(s)
Closes #29103
Steps to test or reproduce
Further comments