Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Omnichannel contact table #29238

Merged
merged 15 commits into from
Jun 12, 2023

Conversation

Kishn0109
Copy link
Contributor

@Kishn0109 Kishn0109 commented May 14, 2023

Proposed changes (including videos or screenshots)

Untitled.video.-.Made.with.Clipchamp.mp4

Issue(s)

Closes #29103

Steps to test or reproduce

  1. Go to the contact page
  2. Create or update existing contact
  3. new changes will reflect in the contact table on clicking on save button

Further comments

  1. As use a customer hook that will handle API calls in place of useEndpointData as it is deprecated.
  2. I use the customer hook approach so that I can easily invalidate the catch using the query key whenever any mutation happens related to the contacts table.
  3. I created the customer hook in the contractual bar dir itself as I did not get any particular folder that was specific to the contacts table

@Kishn0109 Kishn0109 requested a review from a team as a code owner May 14, 2023 18:30
@CLAassistant
Copy link

CLAassistant commented May 14, 2023

CLA assistant check
All committers have signed the CLA.

@Kishn0109 Kishn0109 changed the title Fix: Omnichannel contact table fix: Omnichannel contact table May 14, 2023
@Kishn0109
Copy link
Contributor Author

@ggazzo @hugocostadev please provide feedback for this PR if I did something wrong that I should not it, I will work on it and learn from that, thank you

Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, just need you to take a look on a few things 😉

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

🦋 Changeset detected

Latest commit: e4006fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva
Copy link
Contributor

Hey, @Kishn0109. There's a couple o lint errors, can you take a look?

@Kishn0109
Copy link
Contributor Author

Hi, @aleksandernsilva I have resolved all the linting errors.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #29238 (e4006fa) into develop (742eac7) will increase coverage by 1.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29238      +/-   ##
===========================================
+ Coverage    44.79%   46.49%   +1.69%     
===========================================
  Files          660      698      +38     
  Lines        12489    13031     +542     
  Branches      2202     2228      +26     
===========================================
+ Hits          5595     6059     +464     
- Misses        6571     6648      +77     
- Partials       323      324       +1     
Flag Coverage Δ
e2e 46.46% <100.00%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Contact is not visible after saving.
5 participants