-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle live subscription removal #28717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28717 +/- ##
===========================================
- Coverage 45.39% 40.62% -4.78%
===========================================
Files 685 680 -5
Lines 12879 12828 -51
Branches 2215 2193 -22
===========================================
- Hits 5847 5211 -636
- Misses 6710 7318 +608
+ Partials 322 299 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
guijun13
previously approved these changes
Apr 5, 2023
guijun13
previously approved these changes
Apr 13, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Apr 14, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Apr 14, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Apr 14, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Apr 14, 2023
ggazzo
approved these changes
Jun 5, 2023
gabriellsh
approved these changes
Jun 5, 2023
yash-rajpal
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jun 7, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 7, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 7, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 7, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 9, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 12, 2023
This was referenced Jun 12, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If a user is removed from a room while that room is already opened, then take the user to homepage.
Issue(s)
Steps to test or reproduce
Further comments
TC-476