Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle live subscription removal #28717

Merged
merged 37 commits into from
Jun 12, 2023
Merged

fix: Handle live subscription removal #28717

merged 37 commits into from
Jun 12, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Mar 30, 2023

Proposed changes (including videos or screenshots)

If a user is removed from a room while that room is already opened, then take the user to homepage.

Issue(s)

Steps to test or reproduce

  1. Open a room on user A account.
  2. From user B, remove user A from the room.
  3. Room is still open for user A.

Further comments

TC-476

@yash-rajpal yash-rajpal marked this pull request as ready for review March 30, 2023 21:30
@yash-rajpal yash-rajpal requested review from a team as code owners March 30, 2023 21:30
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #28717 (061ce9b) into develop (742eac7) will decrease coverage by 4.78%.
The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28717      +/-   ##
===========================================
- Coverage    45.39%   40.62%   -4.78%     
===========================================
  Files          685      680       -5     
  Lines        12879    12828      -51     
  Branches      2215     2193      -22     
===========================================
- Hits          5847     5211     -636     
- Misses        6710     7318     +608     
+ Partials       322      299      -23     
Flag Coverage Δ
e2e 40.59% <61.11%> (-4.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

guijun13
guijun13 previously approved these changes Apr 5, 2023
@scuciatto scuciatto added this to the 6.2.0 milestone Apr 12, 2023
guijun13
guijun13 previously approved these changes Apr 13, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 14, 2023
@yash-rajpal yash-rajpal removed the request for review from a team June 7, 2023 08:17
@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 9, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
@kodiakhq kodiakhq bot merged commit c0523e3 into develop Jun 12, 2023
@kodiakhq kodiakhq bot deleted the fix/subs-removed branch June 12, 2023 16:48
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants