Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log ADMIN_PASS environment variable #15307

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Remove log ADMIN_PASS environment variable #15307

merged 1 commit into from
Sep 13, 2019

Conversation

geekgonecrazy
Copy link
Contributor

closes #4806

Remove console log that spits out ADMIN_PASS

sampaiodiego
sampaiodiego approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the initialUser as well?

@geekgonecrazy
Copy link
Contributor Author

Maybe? Usually those if including password are bcrypted... but maybe would be good to omit?

@sampaiodiego sampaiodiego added this to the 2.1.0 milestone Sep 6, 2019
@sampaiodiego sampaiodiego merged commit ae6fb20 into develop Sep 13, 2019
@sampaiodiego sampaiodiego deleted the remove_admin_pass branch September 13, 2019 15:04
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Merged
@geekgonecrazy geekgonecrazy mentioned this pull request Jan 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Setting ADMIN_PASS shows password in log
2 participants
@geekgonecrazy @sampaiodiego