[NEW] User Status Messages #12710

wreiske · 2018-11-23T08:14:48Z

This pull request adds the ability for users to set a custom status message by editing their profile or using a new /status slash command.

Status messages show up in direct messages on the header, as well as in the user info sidebar.

UPDATE

This pull request has changed recently. Please see #12710 (comment)

rodrigok · 2018-11-23T11:58:59Z

@engelgabriel @thiagosanchz what you guys think about this?

geekgonecrazy · 2018-11-23T13:20:21Z

Nice! Would be great to figure out how to surface this where it could be accessed quicker. But I think this is great way to do it! Especially with the slash command which will make it instantly usable even on mobile

iprok · 2018-11-28T21:28:54Z

Very usefull feature. Waiting for it in stable version.

Hudell · 2018-11-29T17:57:16Z

I had been working on #9353 to try and get it merged for a while, maybe both PRs could be merged together as both seem to have features the other lack.

richardt3 · 2018-12-05T11:50:40Z

Looks good - it's something my users keep asking for. Obviously would like to see it in the same place as the current status change, but the slash command makes up for it. Can we get this merged to live pls!

geekgonecrazy · 2018-12-07T17:19:20Z

@Hudell how hard would this be? Are both using close enough approches one could be merged and then the other merged to extend the functionality?

wreiske · 2018-12-07T17:23:02Z

I'm not sure. I haven't looked too far into the code for the other system. I think for the sake of getting this in, we might as well merge this (since it includes the slash command to allow mobile status changes). My team can commit to working on the extra elements needed to set status from within the UI, api rest, as well as working with the IOS and Android apps to get it implemented there.

mickymiek · 2019-01-21T11:44:22Z

What's required to get this in? We're very interested in this feature. We could provide help too if needed :)

@engelgabriel @geekgonecrazy

faziloub · 2019-03-12T13:27:31Z

when will be merged guys ?? any plan ?

wreiske · 2019-03-12T13:33:45Z

This will need to be re-worked since a lot of the surrounding code has been moved around.

I'm willing to put time towards this again, but only with @geekgonecrazy 's or others OK. I don't want to spend more time on a pull-request that is a no-go. Let me know!

geekgonecrazy · 2019-03-12T22:39:55Z

I personally still like this and would like to have it in. Even if the UI changed a bit sometime after merged.

@engelgabriel @thiagosanchz what you guys think about this?

@engelgabriel @thiagosanchz Ping! Still would like thoughts :)

sampaiodiego · 2019-03-12T22:46:46Z

a lot will need to be changed code wise though as I'm about to move everything away from meteor packages..

wreiske · 2019-03-15T04:51:15Z

a lot will need to be changed code wise though as I'm about to move everything away from meteor packages..

Let me know when it's safe for me to start working on this again. I saw a commit recently that moved a bunch of stuff out of the meteor packages. I'll plan a weekend to hammer out the status messages if you think the current implementation will be okay as a starting point.

Essentially:

/status slash command to set status (requires no changes to mobile apps to immediately allow changing of statuses while they implement UI for it)
Change status on the accounts page
Display status in the user bar
Display status in the user info side panel

Hudell · 2019-03-15T14:00:02Z

I'll be working on merging this (along with the other status PR too) next week.

@wreiske if you want to solve the conflicts on this one, it would be a huge help!

wreiske · 2019-03-17T05:16:19Z

I'll be working on merging this (along with the other status PR too) next week.

@wreiske if you want to solve the conflicts on this one, it would be a huge help!

I've updated to the latest build... Also added an Edit Status modal dialog. Trying to figure out how to push/update this pull request. I may need to just start a new pull-request.

wreiske · 2019-03-17T05:44:01Z

Updated to latest greatest 1.0.0-develop.

Ready to merge!... please, before everything moves and I have to update it again... lol!

Admin Settings

wreiske · 2019-03-17T17:50:11Z

Added rocket.chat output message when using the status slash command.

EDIT: Also added "too long"

Edit again: Added ability to edit user status from the admin UI.

geekgonecrazy · 2019-03-23T04:56:39Z

app/api/server/v1/users.js

@@ -378,6 +380,7 @@ API.v1.addRoute('users.updateOwnBasicInfo', { authRequired: true }, {
 			email: this.bodyParams.data.email,
 			realname: this.bodyParams.data.name,
 			username: this.bodyParams.data.username,
+			statusMessage: this.bodyParams.data.statusMessage,


would be really cool if like setAvatar this was a rest call. Imagining the ability to set status from music players, and many other much more practical integrations.

Like my smart toaster! "toast is done".

I'll get this coded up when I wake up unless someone else wants to give it a whack before then.

OK, pushed. @geekgonecrazy please take a look at the changes and let me know if I should change it.

rodrigok · 2019-03-25T13:23:51Z

@wreiske the tests are failing, can you check?

wreiske · 2019-03-25T13:26:30Z

@wreiske the tests are failing, can you check?

Can do. Give me a few...

wreiske · 2019-03-25T13:58:32Z

@wreiske the tests are failing, can you check?

@rodrigok fixed with 8ecbe83. There is something else failing for channels, but I don't think it's related to this.... I could be mistaken.

my meteor npm run chimp-test passes all the way until

Edit: Looks like the build is failing because https://github.com/lovell/sharp-libvips/releases/download/v8.7.0/libvips-8.7.0-linux-x64.tar.gz is returning a 502.

geekgonecrazy · 2019-03-25T16:30:03Z

Edit: Looks like the build is failing because https://github.com/lovell/sharp-libvips/releases/download/v8.7.0/libvips-8.7.0-linux-x64.tar.gz is returning a 502.

looks to be working again. Must have been having an issue at github

wreiske · 2019-03-25T16:32:08Z

Edit: Looks like the build is failing because https://github.com/lovell/sharp-libvips/releases/download/v8.7.0/libvips-8.7.0-linux-x64.tar.gz is returning a 502.

looks to be working again. Must have been having an issue at github

yeah. tests are passing now for mongo 4-0... looks like they are failing at creating a discussion. Unrelated to my changes i think?

wreiske · 2019-06-22T06:03:48Z

Closed in favor of #13933

geekgonecrazy · 2019-06-22T06:36:06Z

🤗 thanks for helping with this feature!

wreiske closed this Mar 17, 2019

wreiske force-pushed the develop branch from 6a9979e to 9b7e01e Compare March 17, 2019 05:39

User Status Messages

97b305f

wreiske reopened this Mar 17, 2019

wreiske added 2 commits March 17, 2019 02:25

Added statusMessage to users api

50bb92b

Added rocket.chat message to status slash command

e61b031

wreiske added 5 commits March 17, 2019 14:06

Added status message too long to slash command

83703b7

Added maxlength to status on profile and edit status modal

2138728

Added edit status from admin user UI

c593690

Merge branch 'develop' into develop

bf95e1a

Merge branch 'develop' into develop

5952752

Hudell self-assigned this Mar 20, 2019

geekgonecrazy reviewed Mar 23, 2019

View reviewed changes

wreiske added 2 commits March 23, 2019 15:31

Merge branch 'develop' into develop

b47597d

setStatus and getStatus rest API

6fdb54b

Fixed chimp test related to user status messages

8ecbe83

wreiske added 2 commits March 25, 2019 10:05

Merge branch 'develop' into develop

ffa8e4d

Merge branch 'develop' into develop

1bcaba2

wreiske added 2 commits March 25, 2019 12:32

Merge branch 'develop' into develop

01df8a4

Merge branch 'develop' into develop

aca976a

marceloschmidt mentioned this pull request Mar 28, 2019

Job title next to status #11403

Closed

Hudell mentioned this pull request Mar 28, 2019

[NEW] Custom User Status #13933

Merged

engelgabriel added this to the 1.1.0 milestone Apr 7, 2019

rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019

wreiske closed this Jun 22, 2019

sdsznsk mentioned this pull request Aug 20, 2019

[FR] Status next to username #15208

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEW] User Status Messages #12710

[NEW] User Status Messages #12710

wreiske commented Nov 23, 2018 •

edited

Loading

rodrigok commented Nov 23, 2018

geekgonecrazy commented Nov 23, 2018

iprok commented Nov 28, 2018

Hudell commented Nov 29, 2018

richardt3 commented Dec 5, 2018

geekgonecrazy commented Dec 7, 2018

wreiske commented Dec 7, 2018 •

edited

Loading

mickymiek commented Jan 21, 2019 •

edited

Loading

faziloub commented Mar 12, 2019

wreiske commented Mar 12, 2019

geekgonecrazy commented Mar 12, 2019 •

edited

Loading

sampaiodiego commented Mar 12, 2019

wreiske commented Mar 15, 2019

Hudell commented Mar 15, 2019

wreiske commented Mar 17, 2019 •

edited

Loading

wreiske commented Mar 17, 2019 •

edited

Loading

wreiske commented Mar 17, 2019 •

edited

Loading

geekgonecrazy Mar 23, 2019

wreiske Mar 23, 2019

wreiske Mar 23, 2019

rodrigok commented Mar 25, 2019

wreiske commented Mar 25, 2019

wreiske commented Mar 25, 2019 •

edited

Loading

geekgonecrazy commented Mar 25, 2019

wreiske commented Mar 25, 2019

wreiske commented Jun 22, 2019

geekgonecrazy commented Jun 22, 2019

[NEW] User Status Messages #12710

[NEW] User Status Messages #12710

Conversation

wreiske commented Nov 23, 2018 • edited Loading

UPDATE

rodrigok commented Nov 23, 2018

geekgonecrazy commented Nov 23, 2018

iprok commented Nov 28, 2018

Hudell commented Nov 29, 2018

richardt3 commented Dec 5, 2018

geekgonecrazy commented Dec 7, 2018

wreiske commented Dec 7, 2018 • edited Loading

mickymiek commented Jan 21, 2019 • edited Loading

faziloub commented Mar 12, 2019

wreiske commented Mar 12, 2019

geekgonecrazy commented Mar 12, 2019 • edited Loading

sampaiodiego commented Mar 12, 2019

wreiske commented Mar 15, 2019

Hudell commented Mar 15, 2019

wreiske commented Mar 17, 2019 • edited Loading

wreiske commented Mar 17, 2019 • edited Loading

wreiske commented Mar 17, 2019 • edited Loading

geekgonecrazy Mar 23, 2019

Choose a reason for hiding this comment

wreiske Mar 23, 2019

Choose a reason for hiding this comment

wreiske Mar 23, 2019

Choose a reason for hiding this comment

rodrigok commented Mar 25, 2019

wreiske commented Mar 25, 2019

wreiske commented Mar 25, 2019 • edited Loading

geekgonecrazy commented Mar 25, 2019

wreiske commented Mar 25, 2019

wreiske commented Jun 22, 2019

geekgonecrazy commented Jun 22, 2019

wreiske commented Nov 23, 2018 •

edited

Loading

wreiske commented Dec 7, 2018 •

edited

Loading

mickymiek commented Jan 21, 2019 •

edited

Loading

geekgonecrazy commented Mar 12, 2019 •

edited

Loading

wreiske commented Mar 17, 2019 •

edited

Loading

wreiske commented Mar 17, 2019 •

edited

Loading

wreiske commented Mar 17, 2019 •

edited

Loading

wreiske commented Mar 25, 2019 •

edited

Loading