Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Config hooks for snap #12351
[NEW] Config hooks for snap #12351
Changes from 8 commits
b6e3923
7e35a1f
ecb374d
f1a9f6e
28efeae
51ba013
91ff2ee
3b5779c
80de23a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to see this expanded to allow configuration of any rocketchat setting from snap.
Something similar to that performed by the ansible rocketchat role here: RocketChat/Rocket.Chat.Ansible@81060e9
(See also RocketChat/Rocket.Chat.Ansible#67)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be right after that, can drop any file with env variables in $SNAP_COMMON directory and they will be exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickbroon the problem we run into is snap settings are very picky. So we can't even use the exact same syntax. If we could we could easily let any setting be set. But we would either have to have a predefined list or a very reliable way of converting between one format and another.
the environment variable file in the root is the current way we're going to recommend doing this.