[FIX] Fix bug when user try recreate channel or group with same name and remove room from cache when user leaves room #12341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hudell
suggested changes
Oct 20, 2018
MarcosSpessatto
changed the title
MarcosSpessatto
changed the title
MarcosSpessatto
changed the title
This was referenced Nov 26, 2018
|
We should probably get this one in. This is one of those weird bugs that has effected people for a while. Way more then have commented or opened issues |
rodrigok
requested changes
Dec 21, 2018
|
@rodrigok done |
rodrigok
approved these changes
Jan 21, 2019
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 1, 2019
…and remove room from cache when user leaves room (#12341) * Fix bug when user try recreate channel or group with same name * Remove flowrouter from cachedcollection * Remove room from cache when user leaves room * Fix deletions and leaves from rooms in client, and rooms stream when delete room
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12013
Closes #12059
Closes #11897