Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Sounds cannot be uploaded from Firefox or IE #6200

Closed
cpitman opened this issue Mar 1, 2017 · 2 comments · Fixed by #11139
Closed

Custom Sounds cannot be uploaded from Firefox or IE #6200

cpitman opened this issue Mar 1, 2017 · 2 comments · Fixed by #11139
Labels
feat: app settings feat: notification
Milestone
0.57.3

Comments

@cpitman
Copy link
Contributor

cpitman commented Mar 1, 2017

Rocket.Chat Version: 0.52 via Docker Image

The current client side code checks for a mime type of "audio/mp3", which is used by chrome and opera (and is also non-standard). Firefox and IE show the standard mime type of "audio/mpeg", which fails validation.
@ghost
Copy link

ghost commented May 23, 2017

I have the same problem (Firefox 53) even if i empty the media file type accepted in /admin/FileUpload.
My /etc/mime.types looks correct :
audio/mpeg mpga mpega mp2 mp3 m4a

@rasos
Copy link
Contributor

rasos commented Jul 3, 2017 •
edited
Loading

Behaviour confirmed: uploading custom sounds only works with Chrome / Chromium, not with FF browser on RC 0.56.

rasos added a commit to rasos/Rocket.Chat that referenced this issue Jul 3, 2017
@rasos
Update soundEdit.html
1242628 
Fix upload custom sound also from Firefox RocketChat#6200
@rasos rasos mentioned this issue Jul 3, 2017
Merged
@rodrigok rodrigok added this to the 0.57.3 milestone Jul 14, 2017
@rasos rasos mentioned this issue Oct 11, 2017
Closed
@vynmera vynmera mentioned this issue Jun 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: app settings feat: notification
Projects
None yet
Milestone
0.57.3
Development

Successfully merging a pull request may close this issue.

[FIX] Custom sound uploader not working in Firefox and IE vynmera/Rocket.Chat
4 participants
@rodrigok @rasos @cpitman @MartinSchoeler