Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"__token __" instead "__token__" in rocketchat_i18n.js #12892

Closed
mzqwe opened this issue Dec 10, 2018 · 1 comment · Fixed by #13463
Closed

"__token __" instead "__token__" in rocketchat_i18n.js #12892

mzqwe opened this issue Dec 10, 2018 · 1 comment · Fixed by #13463

Comments

@mzqwe
Copy link

mzqwe commented Dec 10, 2018 •
edited
Loading

Description:

"__token __" and "__userId __" instead "__token__" and "__userId__"
in programs/server/packages/rocketchat_i18n.js

Steps to reproduce:

  1. Go to "http://rocketchat_host/account/tokens"
  2. Fill "Personal access tokens to REST API"
  3. Click on "Add"
  4. You can see: ''Token: __token __ Your user Id: __userId __" instead of real token and userId.

Expected behavior:

Actual behavior:

Server Setup Information:

  • Version of Rocket.Chat Server: 0.72.1
  • Operating System: Linux
  • Deployment Method: tar
  • Number of Running Instances: 1
  • NodeJS Version: v8.14.0
  • MongoDB Version: 3.6.9

Additional context

Relevant logs:
@leonboot
Copy link
Contributor

leonboot commented Feb 13, 2019 •
edited
Loading

I've just created a Docker based test setup for Rocket.Chat (official image) and configured it using the dutch locale. I'm experiencing this issue as well. Is this issue on the radar, yet?

It seems some i18n files have single underscores, some have double underscores but a trailing (or leading) space between the underscores and variable names.

@leonboot leonboot mentioned this issue Feb 13, 2019
Merged
rodrigok pushed a commit that referenced this issue Feb 13, 2019
@leonboot @rodrigok
[FIX] Translated and incorrect i18n variables (#13463)
b48ffc4 
* Fixes #12892

* Removed trailing and leading spaces in variable names
* Aadded double underscores where only single underscores were used
* Updated some variable names which were translated as well

* Fix __length__
sampaiodiego pushed a commit that referenced this issue Feb 14, 2019
@leonboot @sampaiodiego
[FIX] Translated and incorrect i18n variables (#13463)
a690cde 
* Fixes #12892

* Removed trailing and leading spaces in variable names
* Aadded double underscores where only single underscores were used
* Updated some variable names which were translated as well

* Fix __length__
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this issue Mar 17, 2019
@leonboot @bhardwajaditya
[FIX] Translated and incorrect i18n variables (RocketChat#13463)
f9ed53c 
* Fixes RocketChat#12892

* Removed trailing and leading spaces in variable names
* Aadded double underscores where only single underscores were used
* Updated some variable names which were translated as well

* Fix __length__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Translated and incorrect i18n variables
2 participants
@leonboot @mzqwe