Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fetch members on RoomMembersView #3403

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Sep 24, 2021

Proposed changes

This PR is to fix a TypeError when is fetching members on Room Members View. Because we need to evaluate which version of the server the user is, although if the server is greater or equal than 3.16.0 the result is by property members if is low the property is by records.

Issue(s)

How to test or reproduce

  • You'll need to access 2 different server versions: 1 with version >=3.16.0, and one below.
  • Go to a channel/team/group dm or discussion and check the members that are inside the room.
  • Members should be listed correctly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello merged commit 5bb5d54 into develop Sep 28, 2021
@diegolmello diegolmello deleted the fix.roommembers-fetch branch September 28, 2021 19:34
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [FIX] Fetch members on RoomMembersView

* needed to add a conditional to the response

* result back properly from rocketchat lib

Co-authored-by: Diego Mello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants