Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Canned Responses minor fixes #3400

Merged
merged 3 commits into from
Sep 28, 2021
Merged

[FIX] Canned Responses minor fixes #3400

merged 3 commits into from
Sep 28, 2021

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Sep 23, 2021 •
edited by diegolmello
Loading

Proposed changes

This PR fixes when using canned responses on tablets and remove the refresh control on the canned responses list

Issue(s)

How to test or reproduce

  • The fix to tablets/ipads:

    • You as agent, takes a chat from omnichannel's queue
    • Goes to Canned Responses List and click on button USE
    • You should be redirected to Room view and the message will be written on the message input
    • The same needs to happening when you click the USE on Canned Response Detail view

  • The other fix is to remove the refresh control (that action that the user can pull the scroll, and refresh the page) in the Canned Response List

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 23, 2021
@diegolmello diegolmello changed the title [FIX] Canned Response Minor Fixes [FIX] Canned Responses minor fixes Sep 24, 2021
diegolmello
diegolmello approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello merged commit 80d1403 into develop Sep 28, 2021
@diegolmello diegolmello deleted the fix.canned-response-minor-tweaks branch September 28, 2021 19:25
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @diegolmello
[FIX] Canned Responses minor fixes (RocketChat#3400)
2e49d18 
* fix onChangeText usedCanned on tablet

* removed refreshControl

Co-authored-by: Diego Mello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

@reinaldonetof reinaldonetof

Labels
🛠 fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinaldonetof @diegolmello