Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Allow setGuestName and setGuestEmail to update inputs #627

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hanoii
Copy link
Contributor

@hanoii hanoii commented Aug 7, 2021

Fixes #626

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2021

CLA assistant check
All committers have signed the CLA.

@hanoii
Copy link
Contributor Author

hanoii commented Aug 9, 2021

I actually found a problem here, while adding this the internal state is always overwritten to the default (could be empty) even while typing something new, thus not triggering validations or anything. I noticed this in particular as I am working in both this and #628

@hanoii
Copy link
Contributor Author

hanoii commented Aug 9, 2021

I improved this considerably, I think.

I noticed a bunch of different issues with how different usecases around setting up name and email:

After reading on

I refactored a bit how the props to state were copied as were as handled. Doing most on the constructor and handling default changed by set* functions on componentDidUpdate as the above docs recommended.

@belmeopmenieuwesim
Copy link

Please merge this. It has been an issue for long now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setGuestName and setGuestEmail are not updating the inputs
3 participants