-
Notifications
You must be signed in to change notification settings - Fork 231
[FIX] many-request-error #571
base: develop
Are you sure you want to change the base?
Conversation
@renatobecker, @rafaelblink , @murtaza98 please review. |
window.loadMessagesTimeout = setInterval(() => { | ||
let tmpWaitTime = store.state.loadWaitTime; | ||
if(tmpWaitTime) { | ||
store.setState({loadWaitTime: tmpWaitTime - 1, loadingMessage: `Error, too many requests. Please slow down. You must wait for ${tmpWaitTime} seconds.` }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this message on i18n files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to your comment, does I need to set that message in all i18n files. Like I have to translate that message to all other languages and set it to respective i18n json files. Right? And if this is the case how I can identify which i18n json file belong to which language. Is there any fast way to do this or I have to manually check each i18n json file to check which language it belongs to. Looking forward to your response. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the i18n
command on package.json
files.
You'll use with I18n.t('YOUR TEXT')
and run the command, that command will create the line on i18n files.
} | ||
} | ||
catch(e) { | ||
const waitTime = parseInt(e.data.error.match(/^.*You must wait ([0-9]*) seconds.*$/)[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this message on i18n files.
[FIX] issue #351
when I reproduce the issue and check in inspect , network section , I get below result:
So , I fix this issue by showing this error to user , and ask him to wait as page will reload after given time in error message . For more clarity check this out:
Screen.Recording.2021-03-24.at.3.01.05.AM.mov