Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back and forward shortcuts #916

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

sampaiodiego
Copy link
Member

@RocketChat/electron

I wish I could add them both as shortcuts, but it seems to not be supported right on menu, so only doing few workarounds (like listening to global events or duplicating the menu)..

the motivations are:

  • + [ seems to be used by the majority
  • + have another behavior if you're on a text field (exactly where you're most of the time on rocket.chat) that is to go the beginning of the line.

@sampaiodiego sampaiodiego requested a review from tassoevan October 9, 2018 20:36
@tassoevan tassoevan added this to the 2.14.0 milestone Oct 9, 2018
@tassoevan tassoevan merged commit c29a08c into develop Oct 10, 2018
@tassoevan tassoevan deleted the change-back-forward-shortcuts branch October 15, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants