-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add missing Services menu in application menu on macOS #509
Conversation
Thanks for doing this PR. We'll evaluate and get back to you if there are any changes needed. |
@phidlipus is the Services menu expected to be populated automatically? |
@gdelavald Services menu will be populated only if you have configured some services. By default, if you haven't configured some services you will see only "Services Preferences". |
@gdelavald To my understanding, services menu is stateful, it should populate e.g. if you select a text within the application window. Then you can choose e.g. from text selection related services. The does say it is a system standard menu. Why keep it disabled? |
@phidlipus It's looking good! If I may add a suggestion, could you also add the services submenu to the context menu? I think that would improve the PR even further. Rocket.Chat.Electron/src/public/lib/SpellCheck.js Lines 183 to 217 in 26d9cca
I think it would be trivial to add the same submenu there. |
@gdelavald I might be wrong, but I don't think its common to have the services menu in the context menu |
@alexbrazier I thought I saw some examples of it being useful. Haven't used osx long enough to be sure, I'll leave as is then, if someone feels like it could be useful we can discuss this in the future. |
Thanks for merge. |
@RocketChat/core
Closes #496