Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Snap build #416

Merged
merged 9 commits into from
May 10, 2017
Merged

[New] Snap build #416

merged 9 commits into from
May 10, 2017

Conversation

geekgonecrazy
Copy link
Contributor

Snap build

@geekgonecrazy geekgonecrazy changed the title Snap build [New] Snap build Apr 9, 2017
@engelgabriel engelgabriel added this to the 2.7.0 milestone Apr 10, 2017
@geekgonecrazy
Copy link
Contributor Author

geekgonecrazy commented Apr 11, 2017 •
edited
Loading

Seems to be an issue with electron-builder and multi-arch snap builds. If you do just npm run release -- --x64 it seems to build fine.

Otherwise it gives:

Building Snap for arch ia32
Setting target machine to 'i386'
Error: snapcraft exited with code 1
Error output:
Downloading parts list|                                                        
Building for a different target architecture requires a plugin specific implementation in the 'desktop-glib-only' plugin

Investigating why.. electron-userland/electron-builder#1272

@engelgabriel engelgabriel mentioned this pull request Apr 21, 2017
Closed
@engelgabriel engelgabriel modified the milestones: 2.7.0, 2.9.0 May 5, 2017
engelgabriel and others added 2 commits May 9, 2017 19:26
@engelgabriel
Merge branch 'develop' into add-snap
81db006 
* develop:
  dependencies upgrade
  dependencies upgrade
  dependencies upgrade
  Fix bug on some OS versions on about window, closes #427
  Revert install path, close #435
  Revert install path, close #435
  dependencies upgrade
@geekgonecrazy
removing from electron builder for now
b6d0a03
@engelgabriel engelgabriel merged commit 3543768 into develop May 10, 2017
@engelgabriel engelgabriel deleted the add-snap branch May 10, 2017 23:59
@engelgabriel engelgabriel modified the milestones: 2.8.0, 2.9.0 May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@geekgonecrazy @engelgabriel