[FIX] Resolves issue with timing out when Rocket.Chat is in the background … #1264
Conversation
…by explicitly setting the awayOnWindowBlur: false instead of relying on the default value Also, shortened the idleTimeDetectionInterval to 5000 ms. The original value was 1/2 of the idleTimeLimit, which is way too long to change state (e.g. the default of 300 would only check every 150 seconds!
…ket.Chat being focused, work consistently. This may be too spammy @ 5 seconds, but trigger online/away every time (vs using the cached value) was the only way I could get it consistent.
|
Just to add, this was only tested on a Windows 10 environment, |
|
@ChristineBoersen Do you think it's okay for users to have two away detection policies? I mean, one for browser client (default of 300s) and another one for the desktop client (5s)? |
|
I think they should both be bumped up to 5s.
I'll most likely propose that same change when I do the PR on the non-electron version (working on adding some functionality for showing the time in non-online status similar to lync). They are all in nearly the same portions of code.
And a good chance, (as a second PR to both projects) I'll add it as a server setting, with a default of 5s, and make both clients read from the server provided setting.
…________________________________
From: Tasso Evangelista <[email protected]>
Sent: Wednesday, June 26, 2019 2:32 PM
To: RocketChat/Rocket.Chat.Electron
Cc: Christine Boersen; Mention
Subject: Re: [RocketChat/Rocket.Chat.Electron] [FIX] Resolves issue with timing out when Rocket.Chat is in the background … (#1264)
@ChristineBoersen<https://github.com/ChristineBoersen> Do you think it's okay for users to have two away detection policies? I mean, one for browser client (default of 300s) and another one for the desktop client (5s)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1264?email_source=notifications&email_token=ADIK7XLUHE3KA34RIXV5K33P4OY5LA5CNFSM4H2VYEJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNX7A#issuecomment-505994236>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADIK7XL4ZJ74KW24SSEPPW3P4OY5LANCNFSM4H2VYEJA>.
|
|
@ChristineBoersen While I agree that both would be shorter, the 300s threshold exist because away detection is more complicated on the browser environment -- that's why |
|
I agree (and after looking at how the browser side handles it agree it should be left alone for now) that the browser side is much more complicated since it can't call any OS hooks to truly know away/online |
|
is this fixed in the currently available 2.16.0 dmg/exe files? i tried them but it looks like the electron clients are still going idle/away if they are not in focus. |
|
This fix would have only helped Windows. I know it was in the 2.15.5 version. |
|
I tried Windows and Mac with version 2.16.0 and they both have the same issue. 2.15.5 seems to work fine for both. |
|
Unfortunately, all I did was donate the patch which was part of 2.15.5. My hands are out of the Rocket.Chat project at this point for other reasons... @tassoevan Any idea on the regression issue? |
|
any update on how to fix electron from changing to 'away' when in the background? i've been stuck on 2.15.5 since it seems to be the last version where it worked correctly. I just installed 2.17.8 and my status changes to away while still actively using other programs (osx 10.14.6) |
|
version 2.17.7 also does not handle the status correctly |
@RocketChat/electron
Closes #1260
Resolves issue with Rocket.Chat client going to away when in the background. Solved it by explicitly setting the awayOnWindowBlur: false instead of relying on the default value
Also, shortened the idleTimeDetectionInterval to 5000 ms. The original value was 1/2 of the idleTimeLimit, which is way too long to change state (e.g. the default of 300 would only check every 150 seconds!)