[IMPROVE] Fix remember window state on load #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The AppVeyor build failed, the history shows it's been failing for the past, 5 jobs? |
|
Ouch, it should be misconfigured... Thanks for warn us! |
engelgabriel
added a commit
that referenced
this pull request
Feb 23, 2019
* develop: (51 commits) [FIX] Use Electron notifications (#1101) [FIX] Updates preloads scripts to be compatible with Rocket.Chat >0.74.0 (#1099) Update gulp Update dependencies [IMPROVE] i18next (#1096) [IMPROVE] New tray icons (#1093) [CHORE] Remove unused styles (#1092) [IMPROVE] Remove update-remind-later-dialog (#1076) Fix for basic-auth servers connect (#1074) Fix remember window state on load (#1080) Update provisioning profile Disable artifact collection by AppVeyor (#1081) Add workaround for webview readiness update dependencies electron => 4.0.1 [improve] resolve requested changes Replace istanbul with nyc Work around icon window in e2e tests Add missing id in menu item Enable tests in CI Fix e2e tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/electron
The window state (minimized / maximized) does not persist between when I close and reopen the application. I can see the changes reflected in the
window-state-main.jsonfile but as soon as the application loads those previous values would be overwritten. This is to correctly set the state (window size) on load of the application.