[NEW] Support for MacBooks Touch Bar #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
requested changes
Dec 15, 2018
| this.control = new TouchBarSegmentedControl({ | ||
| segmentStyle: 'separated', | ||
| selectedIndex: this._getActiveServerIndex(), | ||
| segments: this._hosts, |
There was a problem hiding this comment.
What about mapping the hosts with their respective favicons?
There was a problem hiding this comment.
As far as I understand, TouchBarScrubber and TouchBarSegmentedControl allow you to display either an icon or a label. In my experience, the default icon often does not change. I thought it was therefore better to display the label.
If we want to display both Icon and label, then may be we must use a group of buttons (TouchBarButton can display both icon and label) but the buttons are not related to each other. Therefore, we need more logic to color the selected server. I can look into it.
tassoevan
changed the title
tassoevan
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/electron
Closes #918
There are two panels:
TouchBarSegmentedControlorTouchBarScrubber. There is some limits on available space in Touch Bar. If the for displaying of panel elements requires more space than is possible, the entire panel is not displayed. There are two suitable elements in the API for displaying a list of servers.TouchBarSegmentedControlandTouchBarScrubber.TouchBarSegmentedControlis more convenient and allows to set the index of the selected object, but it suffers from the limitations described above.TouchBarScrubberis less convenient to use and does not allow to set the index of the selected item. ButTouchBarScrubberallows you to display more information.I decided to use
TouchBarSegmentedControlif it is possible or there is an opportunity to shorten the names of servers. Otherwise, aTouchBarScrubberis used.I am not very familiar with ElectronJS, so maybe i did something inefficiently but I am ready to refactor if you point out the shortcomings.
There is a demonstration video.