Allow arbitrary service environment variables

[xenithorb]

• New var: rocket_chat_service_environment:

  • This is designed to be a dict, so for every key value pair
    will appear a new line in the rocketchat.service file to
    be exported to the environment of the nodejs process.

• Closes Enhancement: Support ADMIN_USERNAME and ADMIN_PASS role variables #67

[xenithorb]

This would also allow for injecting service environment variables from the commandline too via the ansible-playbook -e flag.

[xenithorb]

CAUTION: Special attention needs to be given to quoting the original value data.

Since this is not well tested. Perhaps at a later date we'll need to | quote the variable or regex_replace.........

[nickbroon]

I'd guess for completeness this should probably also be added to rocketchat_upstart.j2 template for the case of images that use upstart instead of systemd, which I think is the case for Ubuntu Trusty.

[xenithorb]

Tough customer :). Ultimately you're right, though I'm wanting to drop Ubuntu 14 soonish. The hassle it brings to the role is unlike any other distro at the current moment.

[nickbroon]

I wouldn't mind if you dropped Ubuntu Trusty support.

[nickbroon]

I've just tested this, and it appears to work for my use case. It will be great to able to bring up a Rocket.Chat server already configured using Ansible.
Do you plan to merge this to the master branch and release it?
I'd agree that long term quoting is probably a good idea.

[xenithorb]

Soonish, I'm working on the last set of updates for mongodb and other stuff, and then vagrant testing all the distros before I release to master.