タグおよびレシピ回りの拡張を追加 #25
Merged
タグおよびレシピ回りの拡張を追加 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental: Added new format ingredient
Formatted scripts
Reverted tag loading system
Moved mixin classes into tag package
Renamed some fields for RobustumRecipeSerializers.kt
1.16バージョンでは`fabric-loader-junit`がそのままだと正常に動作しない(fabirc-loader#817)ため、先駆者のパッチを適用してfabric-loader自体にASMで書き換えを行った上で動かす必要がある
Add tag related tests
Reworked RegistryEntryList.kt More refined Ingredient codec
|
これでどうでしょうか |
欠けていたKDocを大体追加
|
githubにはtestって名前のユーザーがいるせいで@付けたらメンション飛ぶの草。これ罠すぎない？ 4c7e7c6 |
|
マージはしちゃっていい…のかな？ |
|
あ、それなら一旦全部見ますね(Testだけ見てた |
|
これ、今テスト書いてない部分ってワールドロードが必要orバグが起き得るほどの複雑性を持たない自明なコードって認識で大丈夫ですかね？ |
|
大体そうですね |
turtton
approved these changes
Dec 17, 2024
|
ではマージしますね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.