Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Timeouts no longer working in v0.10.0 #72

Closed
nathany opened this issue Jul 4, 2016 · 2 comments
Closed

Timeouts no longer working in v0.10.0 #72

nathany opened this issue Jul 4, 2016 · 2 comments
Labels
bug

Comments

@nathany
Copy link
Contributor

nathany commented Jul 4, 2016 •
edited
Loading

@leopay reports that net.http.client.Timeout no longer works since moving away from Client.Do in 2d03c35 (necessary to get the type assertion to GoAwayError).
@nathany nathany added the bug label Jul 4, 2016
nathany referenced this issue Jul 4, 2016
@nathany
parse GOAWAY error responses from Apple (#71)
2d03c35 
with latest x/net/http2.
@nathany nathany changed the title Timeout no longer working Timeouts no longer working in v0.10.0 Jul 4, 2016
nathany added a commit that referenced this issue Jul 13, 2016
@nathany
go back to using Client.Do
bd711d7 
ref #72
@nathany nathany mentioned this issue Jul 13, 2016
Merged
@nathany
Copy link
Contributor Author

nathany commented Jul 13, 2016

@leopay #73 should solve this.

nathany added a commit that referenced this issue Jul 15, 2016
@nathany
go back to using Client.Do (#73)
208a65d 
ref #72
@nathany
Copy link
Contributor Author

nathany commented Jul 15, 2016

@leopay This should work again in v0.11.0. Thanks for the report.

@nathany nathany closed this as completed Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathany